Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#497 자동 닉네임 생성 후보 추가 #498

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jinhyeonkwon
Copy link

Summary

It closes #497

@jinhyeonkwon jinhyeonkwon self-assigned this Mar 12, 2024
@jinhyeonkwon jinhyeonkwon linked an issue Mar 12, 2024 that may be closed by this pull request
@jinhyeonkwon
Copy link
Author

최대 글자 조합이 만들어져도 25자 제한을 넘지 않기 위해 커밋 또 했습니다..!

@chlehdwon chlehdwon changed the title ADD: add words to make default nickname #497 자동 닉네임 생성 후보 추가 Mar 12, 2024
Copy link
Contributor

@chlehdwon chlehdwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 재미있는 케이스 많아져서 좋네요~!
추가적으로 PR 만들 때 제가 바꿔준 이름처럼 지어주면 한눈에 확인하기 좋습니다

Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재미있는 닉네임이 많이 생기겠네요! 코멘트 확인 부탁드립니당

@@ -19,6 +19,15 @@ const nouns = [
"전자설계 및 실험",
"기초항공프로젝트",
"화학전공실험",
"일반물리학 I",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 알기로는 I 같은 특수 문자는 넣지 못하는 것으로 알고 있어요! 그냥 일반물리학, 일반화학으로 해야할 듯 합니다 ㅠ

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바꿔서 다시 커밋했습니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 생각해보니.. 닉네임 뒤에 _fa54d 이런식으로 6글자가 추가적으로 붙어야 합니다! 이것을 감안하면 19자까지만 가능할 것 같은데 추가 수정이 필요할 것 같습니다 ㅠㅠ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

자동 닉네임 생성 후보 추가
3 participants