Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AdHocContext create failure #1124

Closed
wants to merge 1 commit into from
Closed

fix: AdHocContext create failure #1124

wants to merge 1 commit into from

Conversation

yogyang
Copy link

@yogyang yogyang commented Oct 24, 2018 •
edited by zeitos

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : #1074

New behavior :
No ERROR

This change is Reviewable

@bsikander
Copy link
Contributor

Thank you for the fix.
A testcase is failing LocalContextSupervisorActor -> "should create adhoc context". Could you please have a look at it?

@bsikander
Copy link
Contributor

Please change your commit message according to the contribution guidelines.

@bsikander
Copy link
Contributor

Ping @fuqiliang

@velvia
Copy link
Contributor

velvia commented Nov 15, 2018

I'm fine with this change other than what @bsikander brought up.

@bsikander
Copy link
Contributor

@fuqiliang could you please have a look at this?

@yogyang yogyang closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yogyang @bsikander @velvia