Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AdHocContext create failure #1124

Open
wants to merge 1 commit into
base: master
from

Conversation

@fuqiliang
Copy link

commented Oct 24, 2018

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : #1074

New behavior :
No ERROR


This change is Reviewable

yujyang
@bsikander

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2018

Thank you for the fix.
A testcase is failing LocalContextSupervisorActor -> "should create adhoc context". Could you please have a look at it?

@bsikander

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2018

Please change your commit message according to the contribution guidelines.

@bsikander

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

Ping @fuqiliang

@velvia

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2018

I'm fine with this change other than what @bsikander brought up.

@bsikander

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2018

@fuqiliang could you please have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.