Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Change typesafe repository to https #1330

Merged
merged 1 commit into from Nov 27, 2020
Merged

fix(build): Change typesafe repository to https #1330

merged 1 commit into from Nov 27, 2020

Conversation

vglagoleva
Copy link

@vglagoleva vglagoleva commented Nov 26, 2020 •
edited by zeitos

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :

Tests for the branch jobserver-0.10.x are failing and #1329 can't be merged.

New behavior :

Apply the patch from the master branch for the Typesafe repository to the jobserver-0.10.x branch as well.

This change is Reviewable

fix(build): Change typesafe repository to https
4f52ee2 
Without it the build is failing at "sbt update" step.
@vglagoleva vglagoleva merged commit ee63e6e into spark-jobserver:jobserver-0.10.x Nov 27, 2020
@vglagoleva vglagoleva deleted the fix_typesaferepo_for_10.x branch November 27, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nibooor Nibooor Nibooor approved these changes

@bsikander bsikander Awaiting requested review from bsikander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vglagoleva @Nibooor