Use spark-submit instead of compute-classpath.sh #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
make logs in spark-submit write to specified log4j config
velvia
added a commit
that referenced
this pull request
Jun 15, 2015
Use spark-submit instead of compute-classpath.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hope is that this will solve a bunch of classpath issues that different folks have been seeing, since job server will launch as a regular Spark application.
You can try this branch out, but note that logging just goes to stdout right now. I haven't figured out how to make Spark use our own log4j config, short of copying our log4j.properties into the
$SPARK_HOME/confdir.Also, @ankit1010 have a look at this. Two thoughts:
spark-submitwould be perfect for launching the forked context JVM. In fact, we may be able to use SparkSubmitDriverBootstrapper.scala, which is part of Spark and means we don't even need to deal with process forking ourselves.