Rails 5 and Spree 3.2 migration #95

damianlegawiec · 2017-02-01T13:47:11Z

Fixes #90

houndci-bot · 2017-02-01T13:47:23Z

db/migrate/20170201125556_add_null_false_to_spree_variants_timestamps.spree.rb

@@ -0,0 +1,7 @@
+# This migration comes from spree (originally 20161014152814)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:23Z

db/migrate/20170201125556_add_null_false_to_spree_variants_timestamps.spree.rb

@@ -0,0 +1,7 @@
+# This migration comes from spree (originally 20161014152814)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:24Z

db/migrate/20170201125555_add_created_at_to_variant.spree.rb

@@ -0,0 +1,9 @@
+# This migration comes from spree (originally 20161014145148)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:24Z

db/migrate/20170201125555_add_created_at_to_variant.spree.rb

@@ -0,0 +1,9 @@
+# This migration comes from spree (originally 20161014145148)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:24Z

db/migrate/20170201125554_add_zipcode_required_to_spree_countries.spree.rb

@@ -0,0 +1,8 @@
+# This migration comes from spree (originally 20160608090604)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:24Z

db/migrate/20170201125554_add_zipcode_required_to_spree_countries.spree.rb

@@ -0,0 +1,8 @@
+# This migration comes from spree (originally 20160608090604)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:24Z

db/migrate/20170201125553_add_missing_indexes_to_spree_taggings.spree.rb

@@ -0,0 +1,15 @@
+# This migration comes from spree (originally 20160511072335)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:24Z

db/migrate/20170201125553_add_missing_indexes_to_spree_taggings.spree.rb

@@ -0,0 +1,15 @@
+# This migration comes from spree (originally 20160511072335)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:24Z

db/migrate/20170201125552_change_collation_for_spree_tag_names.spree.rb

@@ -0,0 +1,10 @@
+# This migration comes from spree (originally 20160511072249)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:25Z

db/migrate/20170201125552_change_collation_for_spree_tag_names.spree.rb

@@ -0,0 +1,10 @@
+# This migration comes from spree (originally 20160511072249)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:25Z

db/migrate/20170201125551_acts_as_taggable_on_spree_migration.spree.rb

@@ -0,0 +1,41 @@
+# This migration comes from spree (originally 20160511071954)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:25Z

db/migrate/20170201125551_acts_as_taggable_on_spree_migration.spree.rb

@@ -0,0 +1,41 @@
+# This migration comes from spree (originally 20160511071954)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:25Z

...igrate/20170201125550_remove_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

+    end
+  end
+
+  def down


Put empty method definitions on a single line.

houndci-bot · 2017-02-01T13:47:25Z

...igrate/20170201125550_remove_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

+    end
+  end
+
+  def down


Put empty method definitions on a single line.

houndci-bot · 2017-02-01T13:47:25Z

...igrate/20170201125550_remove_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

@@ -0,0 +1,11 @@
+# This migration comes from spree (originally 20160509064646)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:25Z

...igrate/20170201125550_remove_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

@@ -0,0 +1,11 @@
+# This migration comes from spree (originally 20160509064646)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:26Z

db/migrate/20170201125549_add_missing_indexes_on_spree_tables.spree.rb

@@ -0,0 +1,68 @@
+# This migration comes from spree (originally 20150314013438)
+class AddMissingIndexesOnSpreeTables < ActiveRecord::Migration[4.2]
+  def change


Assignment Branch Condition size for change is too high. [44.72/15]
Perceived complexity for change is too high. [21/7]

houndci-bot · 2017-02-01T13:47:26Z

db/migrate/20170201125549_add_missing_indexes_on_spree_tables.spree.rb

@@ -0,0 +1,68 @@
+# This migration comes from spree (originally 20150314013438)
+class AddMissingIndexesOnSpreeTables < ActiveRecord::Migration[4.2]
+  def change


Assignment Branch Condition size for change is too high. [44.72/15]
Perceived complexity for change is too high. [21/7]

houndci-bot · 2017-02-01T13:47:26Z

db/migrate/20170201125549_add_missing_indexes_on_spree_tables.spree.rb

@@ -0,0 +1,68 @@
+# This migration comes from spree (originally 20150314013438)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:26Z

db/migrate/20170201125549_add_missing_indexes_on_spree_tables.spree.rb

@@ -0,0 +1,68 @@
+# This migration comes from spree (originally 20150314013438)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:26Z

config/spring.rb

@@ -0,0 +1,6 @@
+%w(


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:27Z

config/spring.rb

@@ -0,0 +1,6 @@
+%w(


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:27Z

config/puma.rb

@@ -1,15 +1,47 @@
-workers Integer(ENV['WEB_CONCURRENCY'] || 2)
-threads_count = Integer(ENV['MAX_THREADS'] || 5)
+# Puma can serve each request in a thread from an internal thread pool.


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:27Z

config/puma.rb

@@ -1,15 +1,47 @@
-workers Integer(ENV['WEB_CONCURRENCY'] || 2)
-threads_count = Integer(ENV['MAX_THREADS'] || 5)
+# Puma can serve each request in a thread from an internal thread pool.


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:27Z

config/initializers/new_framework_defaults.rb

@@ -0,0 +1,23 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:27Z

config/initializers/new_framework_defaults.rb

@@ -0,0 +1,23 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:27Z

config/initializers/application_controller_renderer.rb

@@ -0,0 +1,6 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:28Z

config/initializers/application_controller_renderer.rb

@@ -0,0 +1,6 @@
+# Be sure to restart your server when you modify this file.


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:28Z

config/boot.rb

@@ -1,3 +1,3 @@
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:28Z

config/application.rb

@@ -64,6 +64,7 @@ class Application < Rails::Application
      code: js_polyfill,
      files: ['application.server.js'], # files to load for prerendering
      replay_console: true, # if true, console.* will be replayed client-side
+      code: 'var window = this; ', # window object was removed from react-rails


Duplicated key in hash literal.

houndci-bot · 2017-02-01T13:47:28Z

config/boot.rb

@@ -1,3 +1,3 @@
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T13:47:28Z

config/application.rb

@@ -64,6 +64,7 @@ class Application < Rails::Application
      code: js_polyfill,
      files: ['application.server.js'], # files to load for prerendering
      replay_console: true, # if true, console.* will be replayed client-side
+      code: 'var window = this; ', # window object was removed from react-rails


Duplicated key in hash literal.

https://github.com/codeclimate/ruby-test-reporter/blob/master/CHANGELOG. md#v100-2016-11-03

houndci-bot · 2017-02-01T15:47:03Z

db/migrate/20170201152983_copy_product_slugs_to_slug_history.spree.rb

  def change

 	# do what sql does best: copy all slugs into history table in a single query
 	# rather than load potentially millions of products into memory
 	Spree::Product.connection.execute <<-SQL
 INSERT INTO #{FriendlyId::Slug.table_name} (slug, sluggable_id, sluggable_type, created_at)
-  SELECT slug, id, '#{Spree::Product.to_s}', #{ActiveRecord::Base.send(:sanitize_sql_array, ['?', Time.current])} 
+  SELECT slug, id, '#{Spree::Product.to_s}', #{ApplicationRecord.send(:sanitize_sql_array, ['?', Time.current])} 


Redundant use of Object#to_s in interpolation.
Trailing whitespace detected.

houndci-bot · 2017-02-01T15:47:04Z

db/migrate/20170201152956_change_spree_price_amount_precision.spree.rb

@@ -0,0 +1,9 @@
+# This migration comes from spree (originally 20140508151342)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:04Z

db/migrate/20170201152944_add_considered_risky_to_orders.spree.rb

@@ -0,0 +1,6 @@
+# This migration comes from spree (originally 20140219060952)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:05Z

db/migrate/20170201152915_remove_promotions_event_name_field.spree.rb

@@ -0,0 +1,6 @@
+# This migration comes from spree (originally 20130917024658)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:05Z

db/migrate/20170201152906_add_adjustment_total_to_line_items.spree.rb

@@ -0,0 +1,6 @@
+# This migration comes from spree (originally 20130815000406)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:06Z

db/migrate/20170201152907_add_adjustment_total_to_shipments.spree.rb

@@ -0,0 +1,6 @@
+# This migration comes from spree (originally 20130815024413)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:06Z

db/migrate/20170201152904_expand_order_number_size.spree.rb

@@ -0,0 +1,10 @@
+# This migration comes from spree (originally 20130813140619)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:07Z

db/migrate/20170201152903_add_shipment_total_to_spree_orders.spree.rb

@@ -0,0 +1,6 @@
+# This migration comes from spree (originally 20130813004002)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:07Z

db/migrate/20170201153045_add_null_false_to_spree_variants_timestamps.spree.rb

@@ -0,0 +1,7 @@
+# This migration comes from spree (originally 20161014152814)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:08Z

db/migrate/20170201153044_add_created_at_to_variant.spree.rb

@@ -0,0 +1,9 @@
+# This migration comes from spree (originally 20161014145148)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:08Z

db/migrate/20170201153043_add_zipcode_required_to_spree_countries.spree.rb

@@ -0,0 +1,8 @@
+# This migration comes from spree (originally 20160608090604)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:08Z

db/migrate/20170201153042_add_missing_indexes_to_spree_taggings.spree.rb

@@ -0,0 +1,15 @@
+# This migration comes from spree (originally 20160511072335)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:09Z

db/migrate/20170201153041_change_collation_for_spree_tag_names.spree.rb

@@ -0,0 +1,10 @@
+# This migration comes from spree (originally 20160511072249)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:10Z

db/migrate/20170201153040_acts_as_taggable_on_spree_migration.spree.rb

@@ -0,0 +1,41 @@
+# This migration comes from spree (originally 20160511071954)


Missing frozen string literal comment.

houndci-bot · 2017-02-01T15:47:10Z

...igrate/20170201153039_remove_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

+    end
+  end
+
+  def down


Put empty method definitions on a single line.

houndci-bot · 2017-02-01T15:47:11Z

...igrate/20170201153039_remove_counter_cache_from_spree_variants_to_spree_stock_items.spree.rb

@@ -0,0 +1,11 @@
+# This migration comes from spree (originally 20160509064646)


Missing frozen string literal comment.

damianlegawiec added 5 commits February 1, 2017 13:44

Updated Gemfile for Rails 5 & Spree 3.2

204d063

Missing migrations from Spree 3.2

cd9a379

Rails 5 boilerplate

3e046c0

Variant#stock_items_count was removed in Spree 3.2

3339ec8

Spree 3.2 introduced SpreePaths javascript object, we need to include it

c9208a8

houndci-bot reviewed Feb 1, 2017

View reviewed changes

config/spring.rb

@@ -0,0 +1,6 @@

%w(

Copy link

houndci-bot Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

houndci-bot reviewed Feb 1, 2017

View reviewed changes

config/spring.rb

@@ -0,0 +1,6 @@

%w(

Copy link

houndci-bot Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing frozen string literal comment.

houndci-bot reviewed Feb 1, 2017

View reviewed changes

damianlegawiec temporarily deployed to spark-starter-kit February 1, 2017 13:55 Inactive

damianlegawiec added 3 commits February 1, 2017 15:36

Updated migrations for Spree 3.2 and Rails 5

6abb99b

test_after_commit isn't needed for Rails 5

fb78298

CodeClimate fix

0c93c0b

https://github.com/codeclimate/ruby-test-reporter/blob/master/CHANGELOG. md#v100-2016-11-03

houndci-bot reviewed Feb 1, 2017

View reviewed changes

krzysiek1507 merged commit ff25349 into master Feb 1, 2017

krzysiek1507 deleted the feature/rails-5-spree-3-2 branch February 1, 2017 16:12

		@@ -0,0 +1,7 @@
		# This migration comes from spree (originally 20161014152814)

		@@ -0,0 +1,9 @@
		# This migration comes from spree (originally 20161014145148)

		@@ -0,0 +1,8 @@
		# This migration comes from spree (originally 20160608090604)

		@@ -0,0 +1,15 @@
		# This migration comes from spree (originally 20160511072335)

		@@ -0,0 +1,10 @@
		# This migration comes from spree (originally 20160511072249)

		@@ -0,0 +1,41 @@
		# This migration comes from spree (originally 20160511071954)

		@@ -0,0 +1,11 @@
		# This migration comes from spree (originally 20160509064646)

		@@ -0,0 +1,68 @@
		# This migration comes from spree (originally 20150314013438)

		@@ -0,0 +1,23 @@
		# Be sure to restart your server when you modify this file.

		@@ -0,0 +1,6 @@
		# Be sure to restart your server when you modify this file.

		@@ -1,3 +1,3 @@
		ENV['BUNDLE_GEMFILE'] \|\|= File.expand_path('../../Gemfile', __FILE__)
		ENV['BUNDLE_GEMFILE'] \|\|= File.expand_path('../Gemfile', __dir__)

Rails 5 and Spree 3.2 migration #95

Rails 5 and Spree 3.2 migration #95

Conversation

damianlegawiec commented Feb 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment