Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all page content must be contained by landmarks #286

Open
corinneling opened this issue Oct 5, 2020 · 1 comment
Open

fix: all page content must be contained by landmarks #286

corinneling opened this issue Oct 5, 2020 · 1 comment
Assignees

Comments

@corinneling
Copy link

corinneling commented Oct 5, 2020

To meet WCAG best practice we want to make sure all elements are located within landmarks. For more information view Deque's page on the issue

To fix this, move the markup in the _report.hbs file into the _footer.hbs file

Make sure the markup from the report file is contained within the <footer> tags

Also, make sure to remove references to the report partial from all page templates located here

See screenshot on aXe audit result regarding this issue:
Screen Shot 2020-10-05 at 7 36 38 PM

And a screenshot of the report text on the home page:
apprentice-at-report

@anastasialanz
Copy link

I'll do this one. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants