New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masthead accordion #1009

Merged
merged 9 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@RCopeland
Copy link
Member

RCopeland commented Jan 3, 2019

What does this PR do?

Masthead updates

Please check off completed items as you work.

If a checklist item or section does not apply to your PR
then please remove it.

Documentation

  • Update Spark Docs Angular
  • Update Spark Docs Vanilla
  • Update Component Sass Var/Class Modifier table

Code

  • Build Component in Spark Vanilla (Sass, HTML, JS)
  • Build Component in Spark Angular
  • Unit Testing in Spark Vanilla (100% coverage, 100% passing)
  • Unit Testing in Spark Angular (100% coverage, 100% passing)

Accessibility

Browser Testing (current version and 1 prior)

  • Google Chrome
  • Google Chrome (Mobile)
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

Design Review

  • Design reviewed and approved

Screenshots

Add screenshots to help explain your PR if you'd like. However, this is not
expected.

@RCopeland RCopeland merged commit 58d26c5 into sparkdesignsystem:staging Jan 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@RCopeland RCopeland deleted the RCopeland:ng-narrow-nav branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment