Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masthead accordion #1009

Merged
merged 9 commits into from Jan 4, 2019
Merged

Conversation

RCopeland
Copy link
Collaborator

@RCopeland RCopeland commented Jan 3, 2019

What does this PR do?

Masthead updates

Please check off completed items as you work.

If a checklist item or section does not apply to your PR
then please remove it.

Documentation

  • Update Spark Docs Angular
  • Update Spark Docs Vanilla
  • Update Component Sass Var/Class Modifier table

Code

  • Build Component in Spark Vanilla (Sass, HTML, JS)
  • Build Component in Spark Angular
  • Unit Testing in Spark Vanilla (100% coverage, 100% passing)
  • Unit Testing in Spark Angular (100% coverage, 100% passing)

Accessibility

Browser Testing (current version and 1 prior)

  • Google Chrome
  • Google Chrome (Mobile)
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

Design Review

  • Design reviewed and approved

Screenshots

Add screenshots to help explain your PR if you'd like. However, this is not
expected.

@RCopeland RCopeland added the status: PR review Use this when a PR is ready for review label Jan 3, 2019
@RCopeland RCopeland merged commit 58d26c5 into sparkdesignsystem:staging Jan 4, 2019
@RCopeland RCopeland deleted the ng-narrow-nav branch January 4, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: PR review Use this when a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants