Money input $ gets misplaced when field label wraps to multiple lines #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iner vs using a fixed `margin-top` and updated variable used for the `y` offset
kkwiedacz
requested review from
afebbraro,
RCopeland and
yodasw16
as code owners
|
Angular Built with commit b40fe6a https://app.netlify.com/sites/sparkdesignsystem-angular/deploys/5c478cae3ef412000912fcf1 |
|
React Built with commit b40fe6a https://app.netlify.com/sites/sparkdesignsystem-react/deploys/5c478cae83588c00087bcfe9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the positioning of the money input
$so that no matter the length of the label the$does not get misplaced in the text boxFixes #1083
Please check off completed items as you work.
If a checklist item or section does not apply to your PR
then please remove it.
Documentation
Code
npm run test(100% coverage, 100% passing)gulp test-angular(100% coverage, 100% passing)Accessibility
Browser Testing (current version and 1 prior)
Design Review
Screenshots