[Bug] Angular Inputs: Date Picker Input Calendar does not appear on click #1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When angular is built in --prod, angular date picker input does not work. This is because it's not being packaged correctly with the flag.
Date picker uses a third party library called
tiny-date-picker
. There are a two ways to bring in external libraries: Injection, and import modules.In order to use injection, the library has to have typings, which
tiny-date-picker
does not have.Instead of creating one, we are opting to use the second method of importing it for the sake of simplicity.
Concerns addressed:
Tiny Date picker doesn’t need any of these things.
tiny-date-picker
Further reading:
Associated Issue
#1119
Please check off completed items as you work.
If a checklist item or section does not apply to your PR
then please remove it.
Code
npm run test
(100% coverage, 100% passing)gulp test-angular
(100% coverage, 100% passing)gulp test-react
(100% coverage, 100% passing)Browser Testing (current version and 1 prior)