Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Components Storybook #2215

Merged
merged 10 commits into from
Oct 25, 2019
Merged

Angular Components Storybook #2215

merged 10 commits into from
Oct 25, 2019

Conversation

guern1kn
Copy link
Collaborator

@guern1kn guern1kn commented Oct 23, 2019

What does this PR do?

Adds stories to angular storybook - Footer, Table, Links

Associated Issue

Fixes #1844
Fixes #1862
Fixes #1850

Documentation

Footer

  • Update Spark Docs Angular

Tables

  • Update Spark Docs Angular

Links

  • Update Spark Docs Angular

Code

Footer

  • Build Component in Spark Angular
  • Unit Testing in Spark Angular with gulp test-angular (100% coverage, 100% passing)

Tables

  • Build Component in Spark Angular
  • Unit Testing in Spark Angular with gulp test-angular (100% coverage, 100% passing)

Links

  • Build Component in Spark Angular
  • Unit Testing in Spark Angular with gulp test-angular (100% coverage, 100% passing)

Browser Testing (current version and 1 prior)

Footer

  • Google Chrome
  • Google Chrome (Mobile)
  • Mozilla Firefox
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

Tables

  • Google Chrome
  • Google Chrome (Mobile)
  • Mozilla Firefox
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

Links

  • Google Chrome
  • Google Chrome (Mobile)
  • Mozilla Firefox
  • Mozilla Firefox (Mobile)
  • Microsoft Internet Explorer 11 (only this specific version of IE)
  • Microsoft Edge
  • Apple Safari
  • Apple Safari (Mobile)

Screenshots

Footer
image

Tables
image
image
image
image
image

Links
image
image
image
image

@guern1kn guern1kn self-assigned this Oct 23, 2019
@guern1kn guern1kn added the status: DO NOT MERGE Use on PRs that aren't ready to be merged label Oct 23, 2019
@ssabo1 ssabo1 added this to the 10.21.19-11.1.19 milestone Oct 24, 2019
@guern1kn guern1kn added status: PR review Use this when a PR is ready for review and removed status: DO NOT MERGE Use on PRs that aren't ready to be merged labels Oct 24, 2019
@guern1kn guern1kn added status: DO NOT MERGE Use on PRs that aren't ready to be merged and removed status: PR review Use this when a PR is ready for review labels Oct 24, 2019
@guern1kn guern1kn added status: PR review Use this when a PR is ready for review and removed status: DO NOT MERGE Use on PRs that aren't ready to be merged labels Oct 24, 2019
Copy link
Contributor

@afebbraro afebbraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is perfect! Great work. Approved!

@afebbraro afebbraro merged commit 7136367 into mono-split Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: PR review Use this when a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants