-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored and replaced badphotocopy augmentation & Bug fixed in folding. #59
Conversation
1. Refactored and replaced badphotocopy augmentation. 2. Bug fixed in folding.
@proofconstruction Could you advise on this error? The error mentioned those files need to be reformatted, but is there any guidance on how to format those files? |
This means you should run the |
Thanks, i will try it out later. |
@proofconstruction Looks like there's still error in python 3.6, and i think the image size is <30 (xs = 16), so the pytest didn't include the min image size limitation? Anyway, i will check again by reinstalling python 3.6 later. |
The previous errors should be resolved with my latest push, please check again. |
Can you explain the changes to bleedthrough and the low ink lines augmentations? The change to folding seems to fix the problem, good work |
For bleedthrough, there's chance image size and mask size is not the same, and this is causing error in the blending function. The possible cause is the small image size. For folding, I can see sometimes the input image is in int instead of float or uint8. That will causing error in the warp perspective function so I added code to convert image to float. For applyBlob , when image is too small, size[1] may smaller than size[0] due to the line of code below:
This will causing error in the random.randint function when second number is smaller than first number. Similarly with low ink random lines, the added code is to prevent second number is smaller than first number in the random.randint function. For low ink periodic line, I added code to prevent zero division error. This can be happened when image size is too small. |
Fix unsigned int overflow in remove_noise_fn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work on the bug fixes!
No description provided.