Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Qwiic Quad Relay Firmware Comments #3

Open
dlkeng opened this issue Dec 20, 2021 · 0 comments
Open

Incorrect Qwiic Quad Relay Firmware Comments #3

dlkeng opened this issue Dec 20, 2021 · 0 comments

Comments

@dlkeng
Copy link

dlkeng commented Dec 20, 2021

In the file "Qwiic_Quad_Relay_Firmware.ino", there are a couple of comments that are not correct:

  1. Line 2 states that this code is for "An I2C based KeyPad" when in reality, it's for the "Qwiic Quad Relay"
  2. Lines 206 to 208 state

"If you request the state of three relays, starting with four, you'll get four(0x08), one(0x05), two(0x06)"

when in reality, the code only returns the state of relay four followed by 2 bytes of 0xff indicating invalid relay items. It does not wrap back to the first relay since there is only one requestEvent() occurring for the multiple bytes requested. However, any subsequent follow-on requests will start from relay one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant