Actually using the DISPLAY_TIME to delay the colors. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Came here to make this pull request as well. This should be merged. |
ToniCorinne
pushed a commit
that referenced
this pull request
Dec 3, 2015
Actually using the DISPLAY_TIME to delay the colors.
|
Thanks for the pull requests. I've updated the tutorial instructions to match this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DISPLAY_TIME in circuit #3 is not used, even though it is mentioned in the comments (I guess it should be either deleted or used).
I also made a variation of the sample to use the potentiometer to manage the DELAY_TIME, and also to use a bitwise-based RGB function to improve the way the spectrum if shown.
You can see it here: josea@7fc2018