Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set default network #360

Open
nseidle opened this issue Jun 19, 2024 · 1 comment
Open

Explicitly set default network #360

nseidle opened this issue Jun 19, 2024 · 1 comment

Comments

@nseidle
Copy link
Member

nseidle commented Jun 19, 2024

TCP/UDP Menu:

d) Default network: Hardware Default

What does 'hardware default' mean? I don't think I like this. I expect one or the other. If specific platforms have different defaults, that's fine, but let's not make the user think or have to look up what the default is for their platform. We should just tell them.

@PaulZC PaulZC assigned LeeLeahy2 and unassigned PaulZC Jun 20, 2024
@PaulZC
Copy link
Contributor

PaulZC commented Jun 20, 2024

This is a job for @LeeLeahy2 . As far as I can tell, it is networkGetActiveType that defines the default. Maybe we need to add an extra table which defines the default for each platform - and report that "Default network: Hardware Default (Ethernet)"?

nseidle added a commit that referenced this issue Jun 26, 2024
Fix #360. Limit input to either Ethernet or WiFi, no more NETWORK_TYPE_USE_DEFAULT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants