Add check for http statusCode on file downloads (#2073)

Co-authored-by: Eric Shapiro
sparkle-project · Jan 22, 2022 · 6bed29c · 6bed29c
1 parent fa9bfc1
commit 6bed29c
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/Downloader/SPUDownloader.m b/Downloader/SPUDownloader.m
@@ -159,9 +159,16 @@ - (void)cleanup:(void (^)(void))completionHandler
     });
 }
 
-- (void)URLSession:(NSURLSession *)__unused session downloadTask:(NSURLSessionDownloadTask *)__unused downloadTask didFinishDownloadingToURL:(NSURL *)location
+- (void)URLSession:(NSURLSession *)__unused session downloadTask:(NSURLSessionDownloadTask *) downloadTask didFinishDownloadingToURL:(NSURL *)location
 {
-    if (self.mode == SPUDownloadModeTemporary)
+    NSInteger statusCode = [downloadTask.response isKindOfClass:[NSHTTPURLResponse class]] ? ((NSHTTPURLResponse *)downloadTask.response).statusCode : 200;
+    if ((statusCode < 200) || (statusCode >= 400))
+    {
+        NSString *message = [NSString stringWithFormat:@"A network error occurred while downloading the update. %@ (%ld)", [NSHTTPURLResponse localizedStringForStatusCode:statusCode], (long)statusCode];
+        NSError *error = [NSError errorWithDomain:SUSparkleErrorDomain code:SUDownloadError userInfo:@{ NSLocalizedDescriptionKey: message }];
+        [self.delegate downloaderDidFailWithError:error];
+    }
+    else if (self.mode == SPUDownloadModeTemporary)
     {
         self.downloadFilename = location.path;
         [self downloadDidFinish]; // file is already in a system temp dir