Add more info to auth tool run failure

sparkle-project · Feb 26, 2017 · e54748a · e54748a
1 parent 3b04c45
commit e54748a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Sparkle/SUFileManager.m b/Sparkle/SUFileManager.m
@@ -166,10 +166,11 @@ - (BOOL)_authorizeAndExecuteCommand:(char *)command sourcePath:(char *)sourcePat
     FILE *pipe = NULL;
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    if (AuthorizationExecuteWithPrivileges(_auth, toolPath, kAuthorizationFlagDefaults, arguments, &pipe) != errAuthorizationSuccess) {
+    OSStatus runStatus = AuthorizationExecuteWithPrivileges(_auth, toolPath, kAuthorizationFlagDefaults, arguments, &pipe);
+    if (runStatus != errAuthorizationSuccess) {
 #pragma clang diagnostic pop
         if (error != NULL) {
-            *error = [NSError errorWithDomain:SUSparkleErrorDomain code:SUAuthenticationFailure userInfo:@{ NSLocalizedDescriptionKey:@"Failed to run authorization tool." }];
+            *error = [NSError errorWithDomain:SUSparkleErrorDomain code:SUAuthenticationFailure userInfo:@{ NSLocalizedDescriptionKey:[NSString stringWithFormat:@"Failed to run authorization tool %s (%d).", toolPath, (int)runStatus] }];
         }
         return NO;
     }