undefined symbol: _OBJC_CLASS_$_SPUStandardUpdaterController

[dewren99]

Description of the problem

I have been building the source codes for the Vivaldi browser, however ever since Vivaldi switched to using Sparkle 2.1 (Vivaldi 5.2+) I've been getting the following error (on both x86 and arm64) during the linking stage:

[1/46] SOLINK libchrome_dll.dylib libchrome_dll.dylib.TOC
FAILED: libchrome_dll.dylib libchrome_dll.dylib.TOC 
if [ ! -e "./libchrome_dll.dylib" -o ! -e "./libchrome_dll.dylib.TOC" ] || /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool -l "./libchrome_dll.dylib" | grep -q LC_REEXPORT_DYLIB ; then TOOL_VERSION=1656955941 ../../chromium/build/toolchain/apple/linker_driver.py -Wcrl,strippath,/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip ../../chromium/third_party/llvm-build/Release+Asserts/bin/clang++ -shared  -Wl,-install_name,@rpath/"libchrome_dll.dylib" -Wl,-order_file -Wl,../../chromium/chrome/app/framework.order -ObjC -fuse-ld=lld -Wl,-fatal_warnings -Wl,--icf=all -Wl,--color-diagnostics -arch arm64 -no-canonical-prefixes -Werror -Wl,-dead_strip -nostdlib++ -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -mmacosx-version-min=10.11.0 -Wl,-ObjC -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib -o "./libchrome_dll.dylib" "@./libchrome_dll.dylib.rsp" && { /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool -l "./libchrome_dll.dylib" | grep LC_ID_DYLIB -A 5; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm -gPp "./libchrome_dll.dylib" | cut -f1-2 -d' ' | grep -v U$$; true; } > "./libchrome_dll.dylib.TOC"; else TOOL_VERSION=1656955941 ../../chromium/build/toolchain/apple/linker_driver.py -Wcrl,strippath,/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip ../../chromium/third_party/llvm-build/Release+Asserts/bin/clang++ -shared  -Wl,-install_name,@rpath/"libchrome_dll.dylib" -Wl,-order_file -Wl,../../chromium/chrome/app/framework.order -ObjC -fuse-ld=lld -Wl,-fatal_warnings -Wl,--icf=all -Wl,--color-diagnostics -arch arm64 -no-canonical-prefixes -Werror -Wl,-dead_strip -nostdlib++ -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk -mmacosx-version-min=10.11.0 -Wl,-ObjC -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib -o "./libchrome_dll.dylib" "@./libchrome_dll.dylib.rsp" && { /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool -l "./libchrome_dll.dylib" | grep LC_ID_DYLIB -A 5; /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm -gPp "./libchrome_dll.dylib" | cut -f1-2 -d' ' | grep -v U$$; true; } > "./libchrome_dll.dylib.tmp" && if ! cmp -s "./libchrome_dll.dylib.tmp" "./libchrome_dll.dylib.TOC"; then mv "./libchrome_dll.dylib.tmp" "./libchrome_dll.dylib.TOC" ; fi; fi
ld64.lld: error: undefined symbol: _OBJC_CLASS_$_SPUStandardUpdaterController
>>> referenced by obj/chrome/browser/libbrowser.a(app_controller_mac.o)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../chromium/build/toolchain/apple/linker_driver.py", line 341, in <module>
    LinkerDriver(sys.argv).run()
  File "../../chromium/build/toolchain/apple/linker_driver.py", line 117, in run
    subprocess.check_call(compiler_driver_args, env=env)
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../chromium/third_party/llvm-build/Release+Asserts/bin/clang++', '-shared', '-Wl,-install_name,@rpath/libchrome_dll.dylib', '-Wl,-order_file', '-Wl,../../chromium/chrome/app/framework.order', '-ObjC', '-fuse-ld=lld', '-Wl,-fatal_warnings', '-Wl,--icf=all', '-Wl,--color-diagnostics', '-arch', 'arm64', '-no-canonical-prefixes', '-Werror', '-Wl,-dead_strip', '-nostdlib++', '-isysroot', '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk', '-mmacosx-version-min=10.11.0', '-Wl,-ObjC', '-Wl,-rpath,@loader_path/.', '-Wl,-rpath,@loader_path/../../..', '-L/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr/lib', '-o', './libchrome_dll.dylib', '@./libchrome_dll.dylib.rsp']' returned non-zero exit status 1.
ninja: build stopped: subcommand failed.

I was able to narrow the issue down to the following code block:

SPUStandardUpdaterController* _sparkle_updater_controller;
...
...
if (...) {
  _sparkle_updater_delegate = [[SparkleUpdaterDelegate alloc] init];
  _sparkle_updater_controller = [[SPUStandardUpdaterController alloc]
      initWithUpdaterDelegate: _sparkle_updater_delegate
      userDriverDelegate: nil];
}
...

Although SPUStandardUpdaterController is used multiple times in the code, the error only occurs when [SPUStandardUpdaterController alloc] is called.

Obviously, the issue is related to how Vivaldi integrates Sparkle rather than the Sparkle itself, but I was wondering if there is an obvious mistake the way SPUStandardUpdaterController is being allocated here causing the error.

Do you use Sandboxing in your app?

N/A

Version of Sparkle.framework in the latest version of your app

2.1.0

Version of Sparkle.framework in the old version of app that your users have (or N/A)

N/A

Sparkle's output from Console.app

[zorgiepoo]

This is a linker compiling issue. You may not be linking against Sparkle correctly. The only thing Sparkle 2 might be changing from 1.x in this regard is it uses Versions/B/ rather than Versions/A/ in the framework.. but normally you don't reference a specific version.

Although SPUStandardUpdaterController is used multiple times in the code, the error only occurs when [SPUStandardUpdaterController alloc] is called.

It's not used multiple times in this snippet. The only time it's used is when messaging alloc in your snippet. Declaring a variable of type SPUStandardUpdaterController* is not really using it.

I would check the linker flags you are passing and verify that Sparkle is indeed specified there. As the clang++ error says, you can pass -v to see the full invocation that was used.