Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_appcast fails #1020

Closed
GoodMorningCall opened this issue Jan 28, 2017 · 1 comment
Closed

generate_appcast fails #1020

GoodMorningCall opened this issue Jan 28, 2017 · 1 comment

Comments

@GoodMorningCall
Copy link

Where

Distribution disk image (DMG) includes /Applications symlink.

Reason

The tool assumes that the fist object in the DMG is the app.

Source File

  • generate_appcast/ArchiveItem.swift

function

  • convenience init(fromArchive archivePath: URL, unarchivedDir: URL) throws

Code

line#68

let appPath = items[0];

Update Suggestion

let appPath = apps[0];
kornelski added a commit that referenced this issue Jan 28, 2017
@kornelski
Fix #1020
03abfe2
@kornelski
Copy link
Member

Good catch!

kornelski added a commit that referenced this issue Jan 28, 2017
@kornelski
Merge remote-tracking branch 'origin/1.16.x'
9d966e6 
* origin/1.16.x:
  Fix #1020
@kornelski kornelski mentioned this issue Feb 9, 2017
Closed
martinwinter added a commit to atlasti/Sparkle that referenced this issue Feb 10, 2017
@martinwinter
Merge branch 'upstream/master'
2c02498 
* upstream/master: (235 commits)
  Changelog
  percent encode the filename used in the delta url
  Detect and fail if any two-way dependencies exist in the project
  Update Sparkle.strings
  Update Sparkle.strings
  Don't touch Info.plist unless git version changes
  Add my name to LICENSE
  Fix sparkle-project#1020
  Formatting
  Delta minor version fix
  Simplify minor delta version down to int
  Use the same fileSystemRepresentation function for both parts of the path
  Make normalizedInstallationPathForHost also normalize Unicode
  Test with non-ASCII names
  Typo
  Don't remove the temporary unarchive directory in unit tests
  Removed unimportant changelog entry
  Updated changelog
  Remove nonsense logging I had for debugging purposes
  Add kqueue based termination listener
  ...

# Conflicts:
#	Sparkle/SUBasicUpdateDriver.m
#	Sparkle/SUConstants.h
#	Sparkle/SUConstants.m
#	Sparkle/SUUpdater.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kornelski @GoodMorningCall