Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryDelta fails when tree contains a file with changed case filename #474

Closed
nikolaikrill opened this issue Jan 5, 2015 · 0 comments
Closed

BinaryDelta fails when tree contains a file with changed case filename #474

nikolaikrill opened this issue Jan 5, 2015 · 0 comments

Comments

@nikolaikrill
Copy link

So I've just spent the better part of a day trying to figure out why my deltas are failing to be applied with the latest version of my app. Turns out the problem is that I renamed a file in my app tree, e.g. myfile.plist to MyFile.plist. It would appear that Sparkle does not behave correctly with OS X's case insensitive file system. When applying the delta with the file name change, BinaryDelta fails with "Destination doesn't have expected hash (0e50e73926230b1daaf2819ef8ad3dfe725fd177 != dac90ddf9a293857cbd0b340239b4b4d5dd84da9). Giving up.".

I took a look at the destination tree that had the wrong hash, and sure enough I found that the myfile.plist was completely missing from the destination tree. Please fix this guys, and thanks for this great framework!
zorgiepoo added a commit to zorgiepoo/Sparkle that referenced this issue Apr 3, 2015
@zorgiepoo
Fix BinaryDelta failing on filenames changing case
2dfc849 
When a filename changes case, make sure we have the file deleted in the old tree before being extracted into the new one.
Note that we don't try creating a diff if a file is renamed with a different case, just like we don't track file names changing in other ways.
See issue sparkle-project#474
@zorgiepoo zorgiepoo mentioned this issue Apr 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zorgiepoo @nikolaikrill