Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App icon scaling incorrect in SUUpdateAlert #763

Closed
nriley opened this issue Feb 20, 2016 · 2 comments
Closed

App icon scaling incorrect in SUUpdateAlert #763

nriley opened this issue Feb 20, 2016 · 2 comments

Comments

@nriley
Copy link
Contributor

nriley commented Feb 20, 2016

My app icon is a solid colored rectangle, so there's no point in making a larger icon. Almost everything handles this correctly — except Sparkle’s update window.

tiny icon

I'm happy to fix this since it seems pretty simple by changing the image cell scaling to NSImageScaleProportionallyUpOrDown. I couldn't figure out if Sparkle had a way of automatically producing the xibs, or if I should edit each localized xib individually.

Thanks.

@kornelski
Copy link
Member

We don't generate XIBs. I suppose it can be done with find'n'replace on all XML files.

nriley added a commit to nriley/Sparkle-GitHub that referenced this issue Feb 20, 2016
@nriley
Copy link
Contributor Author

nriley commented Feb 20, 2016

Thanks, done. (Merged #764).

kornelski added a commit that referenced this issue Feb 21, 2016
Scale app icon up if needed in Software Update window (#763)
@nriley nriley closed this as completed Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants