Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strcoll_l() for locale-independent comparisons #2087

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Use strcoll_l() for locale-independent comparisons #2087

merged 1 commit into from
Feb 9, 2022

Commits on Feb 7, 2022

  1. Use strcoll_l() for locale-independent comparisons 

    The update code uses the compareFiles function to determine the sort order of file names in a directory, which is then compared with a list of files in the Sparkle update info. If the list of files of a directory from Sparkle's update is different than what is on disk, the Sparkle abandons the update and does a full download. This bug would prevent Sparkle from updating properly when the file lists are calculated on an English language system, but then checked on a destination Japanese system.

The fix is to use strcoll_l(), which is locale-independent, when comparing file names for sorting. This will ignore any locale changes the host application has made that could potentially affect Sparkle's sort order.
    @dan-rigdon-bel
    dan-rigdon-bel committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    8e0b4a9 View commit details
    Browse the repository at this point in the history