Update Korean localization #2504
Conversation
| @@ -4,17 +4,20 @@ | |||
| /* Class = "NSTextFieldCell"; title = "Text Cell"; ObjectID = "45"; */ | |||
| "45.title" = "Text Cell"; | |||
|
|
|||
| /* Class = "NSTextFieldCell"; title = "Anonymous system profile information is used to help us plan future development work. Please contact us if you have any questions about this.\n\nThis is the information that would be sent:"; ObjectID = "183"; */ | |||
| "183.title" = "익명으로 보내지는 시스템 정보로 차후 프로그램 개발에 도움이 될 수 있습니다. 질문이 있으시면 연락 주십시오.\n\n아래 정보가 전송될 것입니다."; | |||
| /* Class = "NSButtonCell"; title = "Check Automatically"; ObjectID = "176"; */ | |||
There was a problem hiding this comment.
It doesn't matter a lot but the ObjectID should stay as OhZ-1K-DmA. I guess the English one is wrong.
|
|
||
| /* Class = "NSButtonCell"; title = "Don’t Check"; ObjectID = "cCJ-V0-aTi"; */ |
There was a problem hiding this comment.
Same here, this ObjectID was right.
|
Had some minor comments that doesn't really affect anything. Looks good to me. Thanks! |
To avoid mistakes, I copied and pasted the following code base for the work, and I synchronized the comments in the process. Sparkle/Sparkle/en.lproj/SUUpdatePermissionPrompt.strings Lines 8 to 12 in 24f0f39 I didn't sufficiently consider the possibility that this modification might be wrong! It's fortunate that it doesn't matter much. |
Hello!
First of all, I would like to thank the Sparkle project for the amazing feature support.
It made it very easy for me to implement the ability to update my app.
Anyway, while applying Sparkle to my app, I noticed that some Korean localization was missing.
So, I added the missing Korean localization keys and fixed some other expressions that I personally felt were unnatural.
Misc Checklist
Testing
I tested and verified my change by using one or multiple of these methods:
What I tested :
<sparkle:criticalUpdate><sparkle:minimumSystemVersion><sparkle:maximumSystemVersion>macOS version tested: 14.1