Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and use temp extraction directory in generate_appcast again (1.x) #2556

Merged
merged 1 commit into from
May 6, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented May 6, 2024

Port of #2555 to 1.x

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested generate_appcast on unarchiving:

  • DMG file
  • tar.* file
  • zip file

macOS version tested: 14.4.1 (23E224)

Also remove temp directory before extraction.
@zorgiepoo zorgiepoo merged commit d7db589 into master May 6, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the generate-appcast-create-extract-directory-1.x branch May 6, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant