Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xcconfig file for generate_appcast target #953

Merged
merged 2 commits into from Dec 27, 2016

Conversation

zorgiepoo
Copy link
Member

Also remove swift configurations from Common config files, and change swift optimization from fast to whole module.

For some reason unknown to me, generate_appcast fails to build in Xcode 'All' or 'Distribution' target. This can be reproduced in master too, so I don't think it's related to this PR. make release works fine however.

Also remove swift configurations from Common config files, and change swift optimization from fast to whole module.
@zorgiepoo
Copy link
Member Author

Ah, I think it's the target dependency ordering. Place generate_appcast after the other Sparkle targets for the Distribution and All targets; I trust you can make that change @pornel

@kornelski kornelski merged commit ebf8d21 into sparkle-project:master Dec 27, 2016
@kornelski
Copy link
Member

I was unable to reproduce the build failure. All and Distribution worked fine for me.

@jkbullard jkbullard mentioned this pull request Jan 3, 2017
@zorgiepoo
Copy link
Member Author

The errors I am running into is symbols like SUError and SUStandardVersionComparator being unresolved (Swift code not finding those in the obj-c bridging).

One workaround for me I found I believe is adding Sparkle.framework as a target dependency to generate_appcast, and adding 'import Sparkle' in Appcast.swift and DSASignature.swift, to get both make release to work for me and building under Distribution target in Xcode. But this is kind of strange.. @pornel

@kornelski
Copy link
Member

I've seen that briefly, but I think it's an Xcode bug, because it goes away after Clean Build Folder.

@zorgiepoo
Copy link
Member Author

Yeah, I think you're right..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants