Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shape up this repository and upload to maven central #1

Closed
8 tasks done
Tracked by #2437
flavorjones opened this issue Feb 1, 2022 · 1 comment
Closed
8 tasks done
Tracked by #2437

Shape up this repository and upload to maven central #1

flavorjones opened this issue Feb 1, 2022 · 1 comment

Comments

@flavorjones
Copy link
Member

flavorjones commented Feb 1, 2022 •
edited

This is a sub-task of sparklemotion/nokogiri#2437

  • change default head to main
  • tag the initial commit
  • make sure the license is accurate - currently there's both LICENSE and README.md
  • compile and package a jar
  • verify the compiled jar works with nokogiri
  • package docs
  • cut a nokogiri release and upload to maven central
  • document the build process
@flavorjones flavorjones mentioned this issue Feb 1, 2022
Closed
5 tasks
@flavorjones
Copy link
Member Author

Done! See https://repo.maven.apache.org/maven2/org/nokogiri/nekodtd/0.1.11.noko1/

flavorjones added a commit to sparklemotion/nokogiri that referenced this issue May 10, 2022
@flavorjones
dep: pull nekodtd from maven
4efbcc1 
See sparklemotion/nekodtd#1
@flavorjones flavorjones mentioned this issue May 10, 2022
Merged
flavorjones added a commit to sparklemotion/nokogiri that referenced this issue May 10, 2022
@flavorjones
dep: pull nekodtd from maven
7f8f046 
See sparklemotion/nekodtd#1
flavorjones added a commit to sparklemotion/nokogiri that referenced this issue May 11, 2022
@flavorjones
Merge pull request #2538 from sparklemotion/flavorjones-jruby-use-nek…
ca87788 
…odtd-via-maven

dep: pull nekodtd from maven

---

**What problem is this PR intended to solve?**

Closes #2437 

See sparklemotion/nekodtd#1 for full context, this completes the process of migrating to maven-managed dependencies for JRuby.

This PR pulls org.nokogiri:nekodtd from maven central.


**Have you included adequate test coverage?**

No behavioral change, existing tests are fine.


**Does this change affect the behavior of either the C or the Java implementations?**

No behavioral change.
@flavorjones flavorjones mentioned this issue May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flavorjones