-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove fetching all venues across the codebase #1620
Conversation
Code Climate has analyzed commit c7af3b2 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Visit the preview URL for this PR (updated for commit c7af3b2): https://co-reality-staging--preview-pr-1620-7nfntm93.web.app (expires Wed, 28 Jul 2021 19:02:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts/comments/changes/etc.
I'm not sure that any of the usages in the admin components/etc will work currently as this code is, because there is no RelatedVenuesProvider
in-scope for them (and to do so requires being able to give it a specific venueId
).
I haven't looked too deeply into things.. but I expect that most if not all usages of it across the admin components may be wrong/not a good usage of it. It wasn't really written with the admin panel in mind, and I suspect in most cases it's just going to lead to needlessly overfetching data.
…usePreloadedVenue error
They generally don't add value, but console messages from the browser as not being used in the first few seconds of page load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last changes and good to ship
Co-authored-by: mike-lvov <63194656+mike-lvov@users.noreply.github.com>
Co-authored-by: mike-lvov <63194656+mike-lvov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, once reused the selector properly. I can't approve my own PR, but I'll ask @jonboutelle to do it
Looks like all of the things were done
Co-authored-by: mike-lvov <63194656+mike-lvov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gogogo
Replace it with
useRelativeVenues
insteadpartially fixes https://github.com/sparkletown/internal-sparkle-issues/issues/839