Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed background image library text if collection is empty #1876

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

alexey-petrov
Copy link
Contributor

Closes https://github.com/sparkletown/internal-sparkle-issues/issues/716

Done as per https://github.com/sparkletown/internal-sparkle-issues/issues/716#issuecomment-839728182

'Select background image' info text won't appear unless background library collection is not empty

@alexey-petrov alexey-petrov requested a review from a team July 21, 2021 14:35
@alexey-petrov alexey-petrov self-assigned this Jul 21, 2021
@alexey-petrov alexey-petrov added ✨ UI/UX For UI/UX related issues, let's make the platform and customer experience sparkle! ✨ 🐛 bug A bug, error, issue, problem, etc within the platform. labels Jul 21, 2021
@codeclimate
Copy link

codeclimate bot commented Jul 21, 2021

Code Climate has analyzed commit 65b0fee and detected 0 issues on this pull request.

View more on Code Climate.

@alexey-petrov alexey-petrov temporarily deployed to feature-preview July 22, 2021 15:21 Inactive
Copy link
Contributor

@mike-lvov mike-lvov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-lvov mike-lvov enabled auto-merge (squash) July 22, 2021 15:22
@mike-lvov mike-lvov merged commit a713126 into staging Jul 22, 2021
@mike-lvov mike-lvov deleted the fix/remove-bg-text-no-images branch July 22, 2021 15:22
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 65b0fee):

https://co-reality-staging--preview-pr-1876-s1etz9o9.web.app

(expires Thu, 29 Jul 2021 15:25:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@whoaitsaimz
Copy link
Contributor

Also not assigned to correct Epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A bug, error, issue, problem, etc within the platform. ✨ UI/UX For UI/UX related issues, let's make the platform and customer experience sparkle! ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants