Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use HTTPoison #12

Closed
richleland opened this issue Feb 25, 2016 · 5 comments
Closed

Switch to use HTTPoison #12

richleland opened this issue Feb 25, 2016 · 5 comments

Comments

@richleland
Copy link
Contributor

Because it's fly - https://github.com/edgurgel/httpoison
@DavidAntaramian
Copy link
Contributor

@richleland I can take care of this if you want :)

@richleland
Copy link
Contributor Author

hell yeah go for it @DavidAntaramian !

@DavidAntaramian DavidAntaramian mentioned this issue Feb 27, 2016
Open
@DavidAntaramian
Copy link
Contributor

@ewandennis is there a specific reason you chose to implement SparkPost.Endpoint.request/3 with options as a Keyword instead of a Map?

@ewandennis
Copy link
Contributor

@DavidAntaramian - pure oversight. Very happy to accept a PR. Otherwise I'll do a pass on this project when I clear my desk next.

@DavidAntaramian
Copy link
Contributor

@ewandennis I'll include it in this PR since it's easier to implement HTTPoison change with a map.

@DavidAntaramian DavidAntaramian mentioned this issue Mar 12, 2016
Open
DavidAntaramian added a commit to DavidAntaramian/elixir-sparkpost that referenced this issue Apr 15, 2016
@DavidAntaramian
Addresses SparkPost#12:
7f1d843 
* Switch to HTTPoison dependency
* Refactor tests to use HTTPoison
DavidAntaramian added a commit to DavidAntaramian/elixir-sparkpost that referenced this issue Apr 15, 2016
@DavidAntaramian
Fixes SparkPost#12:
784898f 
* Switch to HTTPoison dependency
* Refactor tests to use HTTPoison
@DavidAntaramian DavidAntaramian mentioned this issue Apr 15, 2016
Merged
@jayjun jayjun mentioned this issue May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richleland @DavidAntaramian @ewandennis