Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OAuth 1.0 or decouple HTTP client from base lib #15

Open
mje113 opened this issue Mar 3, 2016 · 3 comments
Open

Add support for OAuth 1.0 or decouple HTTP client from base lib #15

mje113 opened this issue Mar 3, 2016 · 3 comments

Comments

@mje113
Copy link

mje113 commented Mar 3, 2016

Our SparkPost server is sitting behind an OAuth 1.0 gateway on our internal network. While adding OAuth support would probably be a heavyweight approach--I wonder if there would be some way to decouple the specific HTTP client being used, for a more bring-your-own approach?

@richleland
Copy link
Contributor

That's an interesting idea @mje113 - we actually do this type of de-coupling with our PHP library. It's bring your own HTTP lib. Do you have any ideas around what that might look like architecturally? Is there a specific lib you have in mind that you'd want to use?

@DavidAntaramian
Copy link
Contributor

@mje113 Jumping in here because I've been working on getting SparkPost moved over to HTTPoison on top of Hackney over HTTPotion on iBrowse (see #12). We've also discussed using dependency injection with on #13 which in theory would allow you to bring your HTTP communication layer.

@mje113
Copy link
Author

mje113 commented Mar 15, 2016

@DavidAntaramian Cool, I'll check that out. I managed to side-step my OAuth requirement for the time being so this issue fell off my immediate radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants