-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using Wyckoff positions instead of atomic sites #94
Comments
Asymmetric unit cell == primitive unit cell, meaning the minimum # of Wyckoff sites that let you reproduce the full unit cell IIUC. |
Related methods from CDVAE (emphasis added):
|
I think this would be an interesting thing to analyze at some point - does symmetrization lead to more "realistic" structures. My intuition is that, on average, this is the case |
Almost always fewer than the total number of sites, e.g. mp-19841, mp-500, mp-19770. Would cut down the dimensionality by a significant amount, though it also introduces the possibility of representations that aren't able to be reconstructed (disregarding whether the structure would be realistic or not). See e.g. pyxtal: checking compatibility. There's also the question of how to numerically encode the Wyckoff position types. Might be worth digging more into Wren's representation https://github.com/CompRhys/aviary.
The text was updated successfully, but these errors were encountered: