Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode vs. decode symprec, angle_tolerance, and primitive options #97

Merged
merged 11 commits into from
Jun 16, 2022

Conversation

sgbaird
Copy link
Member

@sgbaird sgbaird commented Jun 14, 2022

No description provided.

@sgbaird
Copy link
Member Author

sgbaird commented Jun 14, 2022

#65

@sgbaird sgbaird linked an issue Jun 14, 2022 that may be closed by this pull request
@sgbaird
Copy link
Member Author

sgbaird commented Jun 14, 2022

Need to add tests for this functionality

@sgbaird sgbaird merged commit f58fc69 into main Jun 16, 2022
@sgbaird sgbaird deleted the symprec branch June 16, 2022 22:58
@sgbaird
Copy link
Member Author

sgbaird commented Jun 16, 2022

Something strange with the final coveralls test (showed up as "decreased to zero"). lemurheavy/coveralls-public#586

Keep an eye out to see if this behavior persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does increasing symprec in pymatgen decrease number of sites?
1 participant