Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side-by-side default to toggle fullscreen #90

Open
crynobone opened this issue Sep 7, 2015 · 15 comments
Open

Side-by-side default to toggle fullscreen #90

crynobone opened this issue Sep 7, 2015 · 15 comments

Comments

@crynobone
Copy link

Not sure if this is intended by it would be nice if it was configurable.

screen shot 2015-09-07 at 10 29 39 am
screen shot 2015-09-07 at 10 29 48 am

@WesCossick
Copy link
Member

So by design, side-by-side forces full screen because most embedded editors are not large enough to handle side-by-side well. Are your requesting an option to disable this behavior?

@crynobone
Copy link
Author

Are your requesting an option to disable this behavior?

Yes that would be nice. Or move it above everything else.

Alternatively it would be nice if we could listen to event when the editor enter fullscreen/exit fullscreen so we can tweak our display.

@WesCossick
Copy link
Member

I'll consider these options for future development.

@dongwq
Copy link

dongwq commented Sep 9, 2015

+1, wish this feature.

@WesCossick WesCossick removed the idea label Sep 9, 2015
@WesCossick WesCossick added this to the 1.7.1 milestone Sep 9, 2015
@WesCossick WesCossick self-assigned this Sep 9, 2015
@WesCossick WesCossick modified the milestones: 1.7.1, 1.7.2 Sep 12, 2015
@WesCossick WesCossick removed this from the 1.7.2 milestone Sep 25, 2015
@WesCossick WesCossick removed their assignment Sep 25, 2015
@WesCossick
Copy link
Member

After looking into this further, this is a possibility still, but I'm leaving it as an idea. It will require a decent rethinking of how the side by side mode behaves now, along with a rewrite of the CSS styling. If it's a really important feature to someone, please submit a PR with the necessary modifications.

@hyperking
Copy link

@WesCossick is it possible to simply auto update the preview pane that is typically hidden until the preview button is clicked?

Creating a side by side mode can be handled independently.
update: i am using this method instead. SimpleMDE.prototype.markdown(markdowncontent)

@WesCossick
Copy link
Member

@hyperking Not sure if I understand what you're asking. Can you rephrase that?

@hyperking
Copy link

@WesCossick While typing markdown, I would like the html preview container to auto update without the need of clicking the "eye" icon to preview the markdown in html.

does that help?

@WesCossick
Copy link
Member

I'm not sure why you'd need to render the Markdown if the preview isn't visible.

@WesCossick WesCossick added this to the 2.0.0-beta1 milestone Oct 31, 2015
@KrishnaPG
Copy link

+1 for this There should be a way to avoid the side-by-side option forcing the full screen always.

@volpeo
Copy link

volpeo commented Dec 6, 2015

+1 for this feature, one way or another

@gmolveau
Copy link

gmolveau commented Jan 1, 2016

+1 also :)

@aruizca
Copy link

aruizca commented Jan 2, 2016

+1

1 similar comment
@jstejada
Copy link

+1

@sparksuite sparksuite locked and limited conversation to collaborators Jan 12, 2016
@WesCossick
Copy link
Member

I've locked this issue for further discussion. It has already been assigned to the milestone 2.0.0-beta1 and will be developed in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

9 participants