This repository has been archived by the owner on Oct 18, 2019. It is now read-only.
Feature/healthcheck json #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck
dannypaz
force-pushed
the
feature/healthcheck-json
branch
2 times, most recently
from
0428771
to
bd1ae09
Compare
There was a problem hiding this comment.
@dannypaz This looks good, just one small question regarding logging.
broker-cli/commands/health-check.js
Outdated
| const res = await client.adminService.healthCheck({}) | ||
|
|
||
| if (json) { | ||
| return console.log(JSON.stringify(res)) |
There was a problem hiding this comment.
Not sure about this: do we need to use logger for this to show up in scalyr?
Also, low priority, in wallet.js we do a pretty print (JSON.stringify(transactions, null, 2). Should we create a ticket to remove the pretty printing so it can also be consumed by other programs more easily?
There was a problem hiding this comment.
@bradleystachurski this is such a good observation. Thanks for the catch.
- we should use logger, i will make the change
- pretty printing is actually what we want to do, i've added this to the code
Pretty printing is only there to see it visually (the same for transactions). If there are any use-cases where this doesn't allow someone to use the --json flag effectively, then we can modify.
For us, our current use would be to make sure that different keys in the response are present and I wanted to do this through JSON instead of having to parse the stdout table (although they are arguably the same)
As an example, from the way the code is now, we can see if relayer has RELAYER_OK by running the following:
sparkswap healthcheck --json | grep 'RELAYER_OK' | wc -l
Returning 1 if we are OK and returning 0 if something is wrong
There was a problem hiding this comment.
Gotcha, that makes sense.
treygriffith
approved these changes
May 24, 2019
dannypaz
pushed a commit
that referenced
this pull request
May 29, 2019
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta calculate totals by abstracting fills orders for blockorders change outbound to inbound update ways we get outbound/inbound amounts edits to logging refactor and added methods onto block order for calculating of funds fix tests for calculate active funds add test for new block orders options add tests and fix comment in fill.js added block order tests
dannypaz
pushed a commit
that referenced
this pull request
May 29, 2019
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish
dannypaz
pushed a commit
that referenced
this pull request
May 29, 2019
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish
dannypaz
pushed a commit
that referenced
this pull request
May 30, 2019
* added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish * rename rangeForBlockOrder to rangeForBlockOrderIds * comment change of of
dannypaz
pushed a commit
that referenced
this pull request
May 31, 2019
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta Feature - Add second parameter for range method calls (#529) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish * rename rangeForBlockOrder to rangeForBlockOrderIds * comment change of of update pm2 to resolve axios vuln fix
dannypaz
pushed a commit
that referenced
this pull request
May 31, 2019
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta Feature - Add second parameter for range method calls (#529) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish * rename rangeForBlockOrder to rangeForBlockOrderIds * comment change of of update pm2 to resolve axios vuln fix
dannypaz
pushed a commit
that referenced
this pull request
May 31, 2019
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta Feature - Add second parameter for range method calls (#529) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish * rename rangeForBlockOrder to rangeForBlockOrderIds * comment change of of update pm2 to resolve axios vuln fix
dannypaz
pushed a commit
that referenced
this pull request
Jun 2, 2019
* added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta calculate totals by abstracting fills orders for blockorders change outbound to inbound update ways we get outbound/inbound amounts edits to logging refactor and added methods onto block order for calculating of funds fix tests for calculate active funds add test for new block orders options add tests and fix comment in fill.js added block order tests * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish * rename rangeForBlockOrder to rangeForBlockOrderIds * move methods for getting fills or orders * refactor of calculatingActiveFunds * update docs and update getBlockOrders signature * revert change for removing filter of market * further change * remove unused tet * refactor of orders * added tests for states * add market to active count and fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
--jsonflag to the healthcheck command to allow the healthcheck to be parsable by other programsRelated PRs
List related PRs if applicable
Todos