-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 10 #32
Laravel 10 #32
Conversation
Is this approach of patching version numbers sustainable? Is there a better way? Can we remove the dependency on illuminate/support and other packages? Last question, when do expect a release? |
@Parables kindly see my personal opinions below.
Maybe not but it works
Ideally, a package should follow semantic versioning and drop support for older dependency versions as appropriate. In this particular case, there was no compelling case to drop support for older versions as my PR did not introduce any backward compatible changes At the end of the day, its the maintainers decision as to which dependency versions to support and which ones not to
It would difficult to remove this dependency without having to recreate Laravel specific functionalities e.g Facades, Service Providers, etc. Given this package is specific to Laravel applications,
If you need to test the changes right away while you wait for a tag, you can use |
* Laravel 10 dependencies (#32) (#38) Co-authored-by: Samuel Mwangi <samuel@samuelmwangi.co.ke> * USSD V3 (#39) * Version 3.0 wip * Try github actions for testing * Update build badges * Listing pagination aid * Limit content aid * Making limit content, paginate and terminate play nice together * Format code with php cs fixer * Trim output and add conditional trait * Validate continuing mode * Refector to use method for exception-handler and response * Import InvalidArgumentException in Testing * Specify PHP version * Use decision instead of string for continuing state * Allow creating state or action as initial state with option * Formatting menu helper and caching current page * Rename LimitContent to Truncate and add testing util for time waiting * Timeout resumation is based on last session and not begining of session * Add exception handler command and refactor command tests * Make Ussd useContext chainable and put exception handlers in the ussd directory * Typehint functions * Use docblock for ServiceProvider * Better exceptions * Improve readme * Move some of Ussd functionality to UssdBuilder --------- Co-authored-by: Samuel Mwangi <samuel@samuelmwangi.co.ke>
* Laravel 10 dependencies (#32) (#38) Co-authored-by: Samuel Mwangi <samuel@samuelmwangi.co.ke> * USSD V3 (#39) * Version 3.0 wip * Try github actions for testing * Update build badges * Listing pagination aid * Limit content aid * Making limit content, paginate and terminate play nice together * Format code with php cs fixer * Trim output and add conditional trait * Validate continuing mode * Refector to use method for exception-handler and response * Import InvalidArgumentException in Testing * Specify PHP version * Use decision instead of string for continuing state * Allow creating state or action as initial state with option * Formatting menu helper and caching current page * Rename LimitContent to Truncate and add testing util for time waiting * Timeout resumation is based on last session and not begining of session * Add exception handler command and refactor command tests * Make Ussd useContext chainable and put exception handlers in the ussd directory * Typehint functions * Use docblock for ServiceProvider * Better exceptions * Improve readme * Move some of Ussd functionality to UssdBuilder * Update the install command * Update install command --------- Co-authored-by: Samuel Mwangi <samuel@samuelmwangi.co.ke>
No description provided.