Attempt a checkout before pulling remote #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than attempting to fetch the dependency remotely and then
checking out the revision, the opposite will now happen.
First, gdm will attempt to checkout the correct revision, and on error
the latest changes of the dependency will be fetched and the checkout
re-attempted.
This has two advantages:
1. It allows us to make a private dependency available to gdm without
gdm attempting to fetch it.
2. It's more efficient in the common case that the working tree has
the dependency available locally with the desired revision.
|
good idea, thanks @e-dard! :partyparrot: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than attempting to fetch the dependency remotely and then
checking out the revision, the opposite will now happen.
First,
gdmwill attempt to checkout the correct revision, and on errorthe latest changes of the dependency will be fetched, and the checkout
re-attempted.
This has two advantages:
gdmwithoutgdmattempting to fetch it.the dependency available locally with the desired revision.