Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix SIGFPE caused by signed division overflow
Avoid evaluating INT_MIN / -1 and INT_MIN % -1, which will trap on x86 and crash sparse. Signed-off-by: Xi Wang <xi.wang@gmail.com> Signed-off-by: Christopher Li <sparse@chrisli.org>
- Loading branch information
Showing
3 changed files
with
35 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#include <limits.h> | ||
|
||
static int xd = 1 / 0; | ||
static int xl = 1L / 0; | ||
static int xll = 1LL / 0; | ||
|
||
static int yd = INT_MIN / -1; | ||
static long yl = LONG_MIN / -1; | ||
static long long yll = LLONG_MIN / -1; | ||
|
||
static int zd = INT_MIN % -1; | ||
static long zl = LONG_MIN % -1; | ||
static long long zll = LLONG_MIN % -1; | ||
|
||
/* | ||
* check-name: division constants | ||
* | ||
* check-error-start | ||
div.c:3:19: warning: division by zero | ||
div.c:4:20: warning: division by zero | ||
div.c:5:22: warning: division by zero | ||
div.c:7:25: warning: constant integer operation overflow | ||
div.c:8:27: warning: constant integer operation overflow | ||
div.c:9:34: warning: constant integer operation overflow | ||
div.c:11:25: warning: constant integer operation overflow | ||
div.c:12:27: warning: constant integer operation overflow | ||
div.c:13:34: warning: constant integer operation overflow | ||
* check-error-end | ||
*/ |