Merge pull request #343 from mulimoen/clippy

Fix clippy lints
sparsemat · Dec 19, 2023 · dcbc203 · dcbc203
2 parents d784194 + d1f5c68
commit dcbc203
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/sprs/src/sparse.rs b/sprs/src/sparse.rs
@@ -260,6 +260,7 @@ pub struct TriMatIter<RI, CI, DI> {
 }
 
 mod prelude {
+    #[allow(unused_imports)]
     pub use super::{
         CsMat, CsMatBase, CsMatI, CsMatVecView, CsMatVecView_, CsMatView,
         CsMatViewI, CsMatViewMut, CsMatViewMutI, CsStructure, CsStructureI,

diff --git a/sprs/src/sparse/construct.rs b/sprs/src/sparse/construct.rs
@@ -140,8 +140,7 @@ where
             })
         })
         .collect();
-    let mut to_vstack = Vec::new();
-    to_vstack.reserve(super_rows);
+    let mut to_vstack = Vec::with_capacity(super_rows);
     for (i, row) in mats.iter().enumerate() {
         let with_zeros: Vec<_> = row
             .as_ref()

diff --git a/sprs/src/sparse/csmat.rs b/sprs/src/sparse/csmat.rs
@@ -1023,7 +1023,7 @@ where
         let mut indices: Vec<I> = Vec::with_capacity(max_data_len);
         let mut data = Vec::with_capacity(max_data_len);
 
-        for (_, inner_vec) in self.outer_iterator().enumerate() {
+        for inner_vec in self.outer_iterator() {
             let hot_element = inner_vec
                 .iter()
                 .filter(|e| !e.1.is_nan())

diff --git a/sprs/src/sparse/indptr.rs b/sprs/src/sparse/indptr.rs
@@ -120,7 +120,7 @@ where
     ///
     /// An empty matrix is considered non-proper.
     pub fn is_proper(&self) -> bool {
-        self.storage.get(0).map_or(false, |i| *i == Iptr::zero())
+        self.storage.first().map_or(false, |i| *i == Iptr::zero())
     }
 
     /// Return a view on the underlying slice if it is a proper `indptr` slice,
@@ -215,7 +215,7 @@ where
 
     fn offset(&self) -> Iptr {
         let zero = Iptr::zero();
-        self.storage.get(0).copied().unwrap_or(zero)
+        self.storage.first().copied().unwrap_or(zero)
     }
 
     /// Iterate over the nonzeros represented by this indptr, yielding the