new averaging option for fix temp/rescale #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanmoore1 Please wait for Michael to test this. Once it is ready, this option can be added to the Kokkos version as well. |
stanmoore1
requested changes
Apr 5, 2022
|
just pushed a modified version which I think addresses both Qs |
stanmoore1
force-pushed
the
thermostat-global-option
branch
from
873a1b8
to
249007b
Compare
stanmoore1
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a new "ave" option to fix temp/rescale to allow the current thermal temperature used for velocity rescaling to be the average thermal temperature across all grid cells. Rather than the thermal terperature for each individual cell, as is the current case.
Author(s)
Steve
Backward Compatibility
N/A
Implementation Notes
Provide any relevant details about how the changes are implemented, how correctness was verified, how other features - if any - in SPARTA are affected
Post Submission Checklist
Please check the fields below as they are completed
Further Information, Files, and Links
Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)