Incident flux #416
Merged
Incident flux #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanmoore1
approved these changes
Jun 2, 2023
|
Thanks @timteichmann! |
stanmoore1
added a commit
to stanmoore1/sparta
that referenced
this pull request
Jun 16, 2023
stanmoore1
added a commit
that referenced
this pull request
Jun 16, 2023
Port changes from #416 to Kokkos, fixes numerical regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce
nflux_incidentandmflux_incidentto thecompute_surfcommand. These calculate the incident fluxes on the surface, whereas the originalnfluxandmfluxcommands calculate the respective net fluxes (superposition of incident and reflected fluxes). This is also reflected in the updated doc pages.Closes #361
Author(s)
Tim Teichmann (KIT, ITEP)
Backward Compatibility
yes, new commands are optional and old commands are unchanged.
Implementation Notes
See discussion in #361
Post Submission Checklist
Please check the fields below as they are completed