Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approval | Get allowance/approval component to phase 1 #223

Closed
5 tasks done
SamusElderg opened this issue Apr 19, 2021 · 0 comments · Fixed by #225
Closed
5 tasks done

Approval | Get allowance/approval component to phase 1 #223

SamusElderg opened this issue Apr 19, 2021 · 0 comments · Fixed by #225
Assignees
@SamusElderg

Comments

@SamusElderg
Copy link
Collaborator

SamusElderg commented Apr 19, 2021 •
edited

  • Add 2nd allowance grab in web3Store
  • Rip out the modal / alert stuff
  • Just make it a simple 'press button -> approve -> done'
  • Create a 'light' padlock svg
  • Style the button better
@SamusElderg SamusElderg self-assigned this Apr 19, 2021
SamusElderg added a commit that referenced this issue Apr 19, 2021
@SamusElderg
approval closes #223
3e118c4 
closes #223
@SamusElderg SamusElderg mentioned this issue Apr 19, 2021
Merged
SamusElderg added a commit that referenced this issue Apr 19, 2021
@SamusElderg
Merge pull request #225 from spartan-protocol/allowance-approval-#223
ebe351b 
approval closes #223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamusElderg SamusElderg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

approval closes #223 spartan-protocol/SpartanProtocol-DAppV2
1 participant
@SamusElderg