Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA REFRESH | Refresh walletData[BNB] & component after unlocking/allowing token #225

Closed
SamusElderg opened this issue Nov 8, 2020 · 0 comments · Fixed by #255
Closed

DATA REFRESH | Refresh walletData[BNB] & component after unlocking/allowing token #225

SamusElderg opened this issue Nov 8, 2020 · 0 comments · Fixed by #255
Assignees
@SamusElderg
Labels
data refresh needs community testing Community to pitch in and help test this feature/fix UX

Comments

@SamusElderg
Copy link
Collaborator

SamusElderg commented Nov 8, 2020 •
edited
Loading

The fix is merged but needs community testing please:

  • If you have a token that is not 'approved / unlocked' and want to help test, please go to the 'add liquidity' page (join button on the pools page)
  • Press the 'approve' button and wait for the txn to complete
  • Once it completes, note whether the 'unlock' button automatically changes/updates
  • Also note whether the BNB balance in your wallet updates (might not be noticeable because of tiny gas fees)
  • Report back in here (comment below) and/or the community channels if it works. Feedback always welcome too!

------------------- ISSUE INFO BELOW FOR DEVS --------------------

Contract Method = .approve(ADDR,SUPPLY)

AddLiquidity.js
Parent:

  • unlock()

Children:

  • unlockSparta()
  • unlockToken()

CreatePool.js
Parent:

  • unlockToken()

Children:

  • unlockSparta()
  • unlockAsset()

Swap.js
Parent:

  • unlock()

Children:

  • unlockSparta()
  • unlockToken()
@SamusElderg SamusElderg added the UX label Nov 8, 2020
@SamusElderg SamusElderg self-assigned this Nov 8, 2020
@SamusElderg SamusElderg mentioned this issue Nov 8, 2020
Closed
SamusElderg added a commit that referenced this issue Nov 8, 2020
@SamusElderg
#225
e90c601 
requires some testing before closing the issue which the community can help with by:

- If you have a token that is not approved, go to the 'add liquidity' page
- Click 'approve' button and see if that button automatically changes/updates after the txn approves (without reloading page)
- Also take note of whether the BNB balance updates (gas fees) probably wont be obvious/noticable though as the balance change due to gas is so minor

- we also need to check this works correctly on the 'swap' page (lower priority as i beleive it was already working)

#225
@SamusElderg SamusElderg mentioned this issue Nov 8, 2020
Merged
SamusElderg added a commit that referenced this issue Nov 8, 2020
@SamusElderg
Merge pull request #226 from spartan-protocol/#225
2d8574e 
#225
@SamusElderg SamusElderg added the needs community testing Community to pitch in and help test this feature/fix label Nov 8, 2020
@SamusElderg SamusElderg reopened this Nov 16, 2020
SamusElderg added a commit that referenced this issue Nov 17, 2020
@SamusElderg
closes #225
0adfc6b 
closes #225
@SamusElderg SamusElderg mentioned this issue Nov 17, 2020
Merged
SamusElderg added a commit that referenced this issue Nov 17, 2020
@SamusElderg
Merge pull request #255 from spartan-protocol/#225-finalize
25dad00 
closes #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamusElderg SamusElderg

Labels
data refresh needs community testing Community to pitch in and help test this feature/fix UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

closes #225 spartan-protocol/spartanpools-dapp
1 participant
@SamusElderg