New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD LIQ | BNB Modal get end value being handed to MetaMask #294

Closed

SamusElderg opened this issue Nov 23, 2020 · 0 comments · Fixed by #300

Assignees

Labels

UX

Collaborator

SamusElderg commented Nov 23, 2020

The BNB gas calc modal currently grabs the input value (before calcs)
Let's change it to the value that is handed to MetaMask instead
Also consider making a modal that simply shows the relevant send() data being handed to MetaMask for the user to confirm
We can merge the gasCalc modal with this with a simple alert icon and the same buttons from the modal

SamusElderg added the UX label

SamusElderg self-assigned this

SamusElderg mentioned this issue

Merged

SamusElderg closed this as completed in #300

SamusElderg added a commit that referenced this issue


          Merge pull request #300 from spartan-protocol/#294

6ddb928

#294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment