Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reverse ~ combinator #12

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Conversation

sergei-shabanau
Copy link
Member

Restored the reverse (~) combinator and added tests.

There is a build.sbt update here that

  1. bumps scalaz-base version to around mid-september snapshot.
  2. adds possibility to work will universally quantified functions that are used for natural transformation encoding in v.8. This is also PRed to scalaz-sbt plugin here Added "-Xsource:2.13" compiler option scalaz/scalaz-sbt#22

@codecov-io
Copy link

codecov-io commented Nov 23, 2018

Codecov Report

Merging #12 into master will increase coverage by 7.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage    5.71%   13.15%   +7.44%     
==========================================
  Files           1        1              
  Lines          35       38       +3     
==========================================
+ Hits            2        5       +3     
  Misses         33       33
Impacted Files Coverage Δ
src/main/scala/scalaz/parsers/Iso.scala 13.15% <100%> (+7.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a802079...875399b. Read the comment docs.

@ryanonsrc
Copy link
Collaborator

May consider converting to ScalaCheck later, but for now: LGTM

@ryanonsrc ryanonsrc merged commit 10294c2 into spartanz:master Nov 30, 2018
@sergei-shabanau sergei-shabanau deleted the 0-iso-reverse branch November 30, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants