Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CT-1930 show tooltip on hover select option #95

Merged

Conversation

jakubzegar-appfire
Copy link
Contributor

https://appfire.atlassian.net/browse/CT-1930

In certain situations, customers can't see the full name of the option inside select. To cover these cases, we need an option to show tooltip when hovering over select options.

@jakubzegar-appfire jakubzegar-appfire added enhancement New feature or request good first issue Good for newcomers labels Jan 15, 2024
@@ -1,5 +1,29 @@
<template>
<div
<Tooltip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% happy with this, there is some code duplication, but i couldn't came up with better solution. I've consulted this with Mateusz Zieliński and he also said in that case duplicating some code would be neccesary. If you have any suggestions to make it better, please write that down

@jakubzegar-appfire jakubzegar-appfire merged commit 9053510 into master Jan 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant