block should not be called if IOError raised

Signed-off-by: Konstantin Haase <konstantin.mailinglists@googlemail.com>
spastorino · Jun 14, 2011 · 9d53fb9 · 9d53fb9
1 parent 4856607
commit 9d53fb9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/lib/rack/body_proxy.rb b/lib/rack/body_proxy.rb
@@ -10,10 +10,12 @@ def respond_to?(*args)
 
     def close
       raise IOError, "closed stream" if @closed
-      @body.close if @body.respond_to? :close
+      begin
-    ensure
+        @body.close if @body.respond_to? :close
-      @block.call
+      ensure
-      @closed = true
+        @block.call
+        @closed = true
+      end
     end
 
     def closed?

diff --git a/test/spec_body_proxy.rb b/test/spec_body_proxy.rb
@@ -33,7 +33,8 @@
   end
 
   should 'not close more than one time' do
-    proxy = Rack::BodyProxy.new([]) { }
+    count = 0
+    proxy = Rack::BodyProxy.new([]) { count += 1; raise "Block invoked more than 1 time!" if count > 1 }
     proxy.close
     lambda {
       proxy.close