Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jn rev #8

Merged
merged 6 commits into from
Feb 4, 2020
Merged

Jn rev #8

merged 6 commits into from
Feb 4, 2020

Conversation

Nowosad
Copy link
Contributor

@Nowosad Nowosad commented Jan 15, 2020

@angela-li This PR contains some small changes.
I agree with @Robinlovelace's comment related to adding plots to the documentation.
You just need to add the if (requireNamespace("sf", quietly = TRUE)) bit in examples - see it here - https://nowosad.github.io/spData/reference/alaska.html.

One other thing that need to be solved is the documentation of nyc:

> checking for code/documentation mismatches ... WARNING
  Data codoc mismatches from documentation object 'nyc':
  Variables in data frame 'nyc'
    Code: CODE FORHIS06 FORHIS07 FORHIS08 FORHIS09 FORWH06 FORWH07
          FORWH08 FORWH09 HHSIZ00 HHSIZ02 HHSIZ05 HHSIZ08 HHSIZ1990
          KIDS2000 KIDS2005 KIDS2006 KIDS2007 KIDS2008 KIDS2009 NAME
          PUBAST00 PUBAST90 RENT2002 RENT2005 RENT2008 RENTPCT02
          RENTPCT05 RENTPCT08 SUBBOROUGH YRHOM02 YRHOM05 YRHOM08 bor_subb
    Docs: FORHIS06 FORWH06 HHSIZ00 HHSIZ02 HHSIZ1990 KIDS2000 PUBAST90
          RENT2002 RENTPCT02 YRHOMO02

I do not know what is the best solution here: (a) list all of the variables in the documentation, (b) remove this list entirely, (c) something else?...

@angela-li
Copy link
Member

Finally got a chance to look at this post-conf, thank you for your support! Just to clarify, what does adding the package doc (in 454cb65) do?

@angela-li angela-li merged commit 83aa5fd into spatialanalysis:master Feb 4, 2020
This was referenced Feb 4, 2020
@Nowosad
Copy link
Contributor Author

Nowosad commented Feb 8, 2020

Hi @angela-li - just try:

library(geodaData)
?geodaData

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants