New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problematic themes for sphinx_copybutton #376
Comments
Guess most things can be fixed by explicitly setting
|
@s-weigand Would you mind creating an issue or PR for https://github.com/choldgraf/sphinx-copybutton? The [UPDATE: I've created ITCase/itcase_sphinx_theme#38] |
I can do this, but first I will create a tool to generate all the different theme docs in one swoop. I got a first draft/idea for this, which would work as follows:
Messing with git (via GitPython) isn't too pretty, but IMHO the most elegant way to prevent duplication and the resulting maintenance. What are your thoughts on this? Do you think this is worth a shot for some dev comfy? P.S.: The diff extraction allready works 😄 |
That's a really good idea! I've just manually (and temporarily) re-based the theme branches onto the work-in-progress branch to try different themes. I've made a script for re-basing all theme remotes: https://github.com/spatialaudio/nbsphinx/blob/master/git_rebase_theme_branches.sh Something similar for local usage would be great!
Instead of copying, you could probably use
This sounds just like rebasing. This way, Git can do all the diffing for you.
I normally have the "spatialaudio" URL as If you prefer, we can also change the name to
I've never used GitPython, but if you think it's a good tool for this, I'm fine with it.
Definitely! When running Sphinx on all those different theme directories, it might be a good idea to use the same "doctree directory" for all of them (using the |
…ache and reduce build time considerably, props go to spatialaudio#376 (comment)
…ache and reduce build time considerably, props go to spatialaudio#376 (comment)
I made a PR at |
Thanks!
This is the source: https://bitbucket.org/ecollins/cloud_sptheme/ |
Can't figure out what is going wrong in When I tried: ::after{
display: none;
} The Also the binder badge in img[alt="Binder badge"]{
width: unset;
} The inline style of the |
The Schrödinger behavior of the The Binder badge is not part of |
I will open a ticket at The other themes, as I saw it, set article.pytorch-article img {
width: 100%;
} IMHO having the |
So this is a bug in the pytorch theme?
If that's just a work-around for the bug mentioned above, I would prefer to fix the bug instead. |
It has yet to be determined for each of those cases if the problem has to be fixed in the theme itself, in
sphinx_copybutton
or here innbsphinx
.A separate issue/PR should be made for each of these:
icon too low in Firefox, not even visible in Chromium [fixed by https://github.com/choldgraf/sphinx-copybutton/pull/54]
when clicking, tooltip and icon move to the left margin, a bit erratic
icons are huge, clicking doesn't seem to work [see Theme ignores CSS files added by extensions ITCase/itcase_sphinx_theme#38, removed in Remove links to "itcase" theme #385]
click doesn't copy [this seems to work now, probably fixed by https://github.com/choldgraf/sphinx-copybutton/pull/54?]
distance to the top is slightly too high [fixed by https://github.com/choldgraf/sphinx-copybutton/pull/54]
click doesn't copy [this seems to work now, probably fixed by https://github.com/choldgraf/sphinx-copybutton/pull/54?]
icon not visible
red line in icon (better visible on hover) [fixed by https://github.com/choldgraf/sphinx-copybutton/pull/54]
In multiple themes the tooltip font is too large or too small. This is not a biggie, but maybe it can be improved for some themes.
The text was updated successfully, but these errors were encountered: