Bugfix/unr 1358 schema generation #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
size/L
aleximprobable
force-pushed
the
bugfix/unr-1358-schema-generation
branch
from
92beffb
to
5a3c338
Compare
improbable-prow-robot
added
size/M
Vatyx
reviewed
May 1, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp
Outdated
Show resolved
Hide resolved
Vatyx
reviewed
May 1, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp
Outdated
Show resolved
Hide resolved
Vatyx
reviewed
May 1, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp
Outdated
Show resolved
Hide resolved
Vatyx
reviewed
May 1, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp
Outdated
Show resolved
Hide resolved
Vatyx
reviewed
May 1, 2019
SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp
Outdated
Show resolved
Hide resolved
Vatyx
approved these changes
May 1, 2019
improbable-prow-robot
added
size/XXL
…emaGenerator.cpp Co-Authored-By: aleximprobable <48994762+aleximprobable@users.noreply.github.com>
Made nullptr and 0 checks explicit. Co-Authored-By: aleximprobable <48994762+aleximprobable@users.noreply.github.com>
aleximprobable
force-pushed
the
bugfix/unr-1358-schema-generation
branch
from
883e8f6
to
d2269ff
Compare
improbable-prow-robot
added
size/M
improbable-valy
approved these changes
May 1, 2019
joshuahuburn
approved these changes
May 1, 2019
improbable-valy
pushed a commit
that referenced
this pull request
May 1, 2019
* Fixed issue, where Schema Generator could generate id 0 * Update SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp Co-Authored-By: aleximprobable <48994762+aleximprobable@users.noreply.github.com> * Bring back newline * Apply suggestions from code review Made nullptr and 0 checks explicit. Co-Authored-By: aleximprobable <48994762+aleximprobable@users.noreply.github.com>
improbable-valy
pushed a commit
that referenced
this pull request
May 1, 2019
* Fixed issue, where Schema Generator could generate id 0 * Update SpatialGDK/Source/SpatialGDKEditor/Private/SchemaGenerator/SchemaGenerator.cpp Co-Authored-By: aleximprobable <48994762+aleximprobable@users.noreply.github.com> * Bring back newline * Apply suggestions from code review Made nullptr and 0 checks explicit. Co-Authored-By: aleximprobable <48994762+aleximprobable@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.
Description
Fixed a UNR-1358 bug, where Schema Generator could generate ids equal to 0.
Release note
Fixed an issue, where Schema Generator could generate ids equal to 0.
Tests
Adding new components and fields in components (including Handover) shouldn't lead to 0 ids being generated.
Primary reviewers
@joshuahuburn @Vatyx