Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

UTY-2647: bad sync point in ecs view manager #1430

Merged
merged 8 commits into from Aug 3, 2020
Merged

UTY-2647: bad sync point in ecs view manager #1430

merged 8 commits into from Aug 3, 2020

Conversation

BryanJY-Wong
Copy link
Contributor

@BryanJY-Wong BryanJY-Wong commented Jul 17, 2020 •
edited

Description

  • Bad sync point by looking up components using WorkerSystem during an update in SpatialOSReceiveSystem
  • Changed codegen to use SpatialOSReceiveSystem instead

Tests

  • help?

Documentation

  • Changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@BryanJY-Wong BryanJY-Wong self-assigned this Jul 17, 2020
@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2647

@improbable-prow-robot improbable-prow-robot added A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: maintenance Area: Project maintenance or hygiene A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground A: tooling Area: Tooling size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Jul 17, 2020
@BryanJY-Wong BryanJY-Wong changed the base branch from master to develop July 17, 2020 15:05
@improbable-prow-robot improbable-prow-robot added size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Jul 17, 2020
@BryanJY-Wong BryanJY-Wong marked this pull request as draft July 17, 2020 15:17
@BryanJY-Wong
Copy link
Contributor Author

@zeroZshadow does removing the view not render this redundant? Unless its a different view

@BryanJY-Wong BryanJY-Wong marked this pull request as ready for review July 20, 2020 09:34
jamiebrynes7
jamiebrynes7 reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the workerSystem used in the generated classes anymore? If not, lets get rid

@BryanJY-Wong
Copy link
Contributor Author

Is the workerSystem used in the generated classes anymore? If not, lets get rid

Yes, its used to map spatial-unity entities.

jamiebrynes7
jamiebrynes7 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but I'm not sure how to test this. Was there not a repro case in the original ticket?

Also don't forget a changelog!

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@BryanJY-Wong BryanJY-Wong merged commit 384d61c into develop Aug 3, 2020
@improbable-prow-robot improbable-prow-robot deleted the bug/bad-sync-point-in-ecs-view-manager branch August 3, 2020 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeroZshadow zeroZshadow zeroZshadow approved these changes

@paulbalaji paulbalaji paulbalaji approved these changes

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

Assignees

@BryanJY-Wong BryanJY-Wong

Labels
A: build-system Area: Build system feature module A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: maintenance Area: Project maintenance or hygiene A: player-lifecycle Area: Player lifecycle feature module A: playground Area: Playground A: tooling Area: Tooling jira/UTY size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BryanJY-Wong @improbable-prow-robot @zeroZshadow @paulbalaji @jamiebrynes7