This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Bugfix - Code generation with fields called value #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
the
size/L
ghost
approved these changes
Nov 14, 2018
paulbalaji
approved these changes
Nov 14, 2018
jamiebrynes7
force-pushed
the
bugfix/codegen-fields-named-value
branch
from
c0671ac
to
90fb652
Compare
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* Bug fix - Only set relevant if not being torn off Also some flyby fixes: - fix merge issue causing FinalReplicatedCount to be incremented twice - Move channel search to before the relevant actors check - minor style change * Replicate even if not bIsRelevant, if IsNetReady This fixes an issue with tearoff, where otherwise the final update will not be sent, since torn off actors are not marked as relevant. * Remove the FinalRelevantCount variable (it is never actually used) * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp Co-Authored-By: BenNaccarato <bennaccarato@improbable.io> * Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialNetDriver.cpp Co-Authored-By: BenNaccarato <bennaccarato@improbable.io> * Added check for TearOff actors when replicating
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the problem described in #607 and adds a test case to our test schema to stop regressions.
Tests
Added a test case.
Documentation
Changelog
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.
@firtina-improbable @paulbalaji